Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static location and live location support #1423

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

arnautov-anton
Copy link
Contributor

@arnautov-anton arnautov-anton commented Dec 19, 2024

Description of the changes, What, Why and How?

This PR adds

  • LiveLocationManager class - helper to handle registered live locations (see use in React SDK PR)
  • Channel.sendStaticLocation - sends a message with single static_location attachment
  • Channel.startLiveLocationSharing - sends a message with single live_location attachment and dispatches local live_location_sharing.started event to notify LiveLocationManager instances
  • Channel.stopLiveLocationSharing - dispatches local live_location_sharing.stopped event to notify LiveLocationManager instances (should probably just update message attachment with stopped_sharing instead)

@arnautov-anton arnautov-anton force-pushed the feat/live-location-manager branch from b3cfe1f to 36d56e1 Compare January 9, 2025 15:11
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Size Change: +31.7 kB (+6.83%) 🔍

Total Size: 495 kB

Filename Size Change
dist/browser.es.js 108 kB +7.14 kB (+7.07%) 🔍
dist/browser.full-bundle.min.js 60 kB +3.01 kB (+5.29%) 🔍
dist/browser.js 109 kB +7.19 kB (+7.03%) 🔍
dist/index.es.js 108 kB +7.14 kB (+7.06%) 🔍
dist/index.js 109 kB +7.18 kB (+7.02%) 🔍

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant