Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-302] menu item stateless components #5608

Merged
merged 22 commits into from
Feb 5, 2025

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

Add components into the component factory related to the menu items and channel menu, messages menu and reactions menu and reaction picker.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner February 3, 2025 16:48
# Conflicts:
#	stream-chat-android-compose/api/stream-chat-android-compose.api
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatComponentFactory.kt
Copy link
Contributor

github-actions bot commented Feb 3, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.74 MB 8.75 MB 0.00 MB 🟢

# Conflicts:
#	stream-chat-android-compose/api/stream-chat-android-compose.api
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channels/ChannelsScreen.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatComponentFactory.kt
@aleksandar-apostolov
Copy link
Collaborator Author

Merge only after snapshot tests are done for the ExtendedReactionPickerOptions

# Conflicts:
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatComponentFactory.kt
@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) February 5, 2025 11:37
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
51.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 582e8b8 into develop Feb 5, 2025
11 of 12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the AND-302-menu-item-statless-components branch February 5, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants