Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-297] Add SearchInput stateless component factories. #5604

Merged
merged 7 commits into from
Feb 5, 2025
Merged

[AND-297] Add SearchInput stateless component factories. #5604

merged 7 commits into from
Feb 5, 2025

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

Introduce factory methods in ChatComponentFactory for SearchInput.

🧪 Testing

  1. Override any of the new factory methods in the CustomChatComponentFactory
  2. Open compose sample app
  3. Enter a query in the channel list search field
  4. The changes made in the factory should be visible in the field/result items.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.75 MB 8.75 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review January 31, 2025 12:46
@VelikovPetar VelikovPetar requested a review from a team as a code owner January 31, 2025 12:46
skydoves
skydoves approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

PetarVelikov added 5 commits February 3, 2025 12:38
Merge branch 'develop' into feature/search-results-stateless-componen…
7686627 
…t-factories

# Conflicts:
#	CHANGELOG.md
#	stream-chat-android-compose/api/stream-chat-android-compose.api
[AND-297] Apply spotless.
46bd324
Merge branch 'develop' into feature/search-results-stateless-componen…
43a8ae9 
…t-factories

# Conflicts:
#	CHANGELOG.md
#	stream-chat-android-compose/api/stream-chat-android-compose.api
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatComponentFactory.kt
[AND-297] Apply spotless.
99f25e3
Merge branch 'develop' into feature/search-results-stateless-componen…
2bbc019 
…t-factories

# Conflicts:
#	CHANGELOG.md
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
52.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@andremion andremion merged commit 071101a into develop Feb 5, 2025
11 of 12 checks passed
@andremion andremion deleted the feature/search-results-stateless-component-factories branch February 5, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VelikovPetar @skydoves @andremion