-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kvp search #18
base: master
Are you sure you want to change the base?
Kvp search #18
Conversation
Hey Remy, I haven't yet taken the time to think about the UI, but the way it is now, I'm guessing you want to allow someone to filter on KVP and tag at the same time. Is that right? |
Hey, thanks for your reviewing
I know. This was just the very first attempt, to understand a bit the logic behind and to show you what I have in mind. Instead of the ID, I should put the key but I haven't had the time yet.
Yes, but I think it is already the case. What I had in mind was to be able to pile-up multiple key/value filters, a bit like this, with a I'll try to find a bit of time this week or next week to move on this. |
Hi Tom, I have a minimal working example, with two different KVPs to search, in combinaison with tags.
But it should already be possible to test it |
Hi @Tom-TBT
I've begin to work on the key-value search. For now, it only search for keys (not values) in different namespaces.
Next steps
I'm thinking about having different fields for keys and for values, but each fields being filled with only one choice (I found out that ChoiceField is doing this trick). But I also wanted to do it interactive by adding fields dynamically. For example, we can have a "+" button that creates a new fields for key/value in order to not hard code a definite number of those fields.
Problem : it seems that the way
TagSearchForm
is written does not allow having fields as a list that we can populated dynamically. I don't have any idea for now on how to solve this.