Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add trek schema parser #4349

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

✨ Add trek schema parser #4349

wants to merge 54 commits into from

Conversation

justinefricou
Copy link
Contributor

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@justinefricou justinefricou changed the title ✨ Add data gouv parser ✨ Add data gouv trek parser Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 85.38012% with 25 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (63f01f6) to head (fc46f32).

Files with missing lines Patch % Lines
geotrek/trekking/parsers.py 85.38% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4349      +/-   ##
==========================================
- Coverage   98.44%   98.34%   -0.10%     
==========================================
  Files         267      267              
  Lines       20936    21105     +169     
==========================================
+ Hits        20610    20756     +146     
- Misses        326      349      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 25, 2024

Geotrek-admin    Run #10261

Run Properties:  status check passed Passed #10261  •  git commit 7afeb90694 ℹ️: Merge 552d829cb5b8f6fee977ba31ee072426b75f4cc9 into 63f01f6d6edac0b02498ad589f94...
Project Geotrek-admin
Branch Review refs/pull/4349/merge
Run status status check passed Passed #10261
Run duration 02m 07s
Commit git commit 7afeb90694 ℹ️: Merge 552d829cb5b8f6fee977ba31ee072426b75f4cc9 into 63f01f6d6edac0b02498ad589f94...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@camillemonchicourt
Copy link
Member

Pour moi ce parser n'est pas spécialement lié à Data.gouv.fr mais plutôt au schéma de rando (https://schema.data.gouv.fr/PnX-SI/schema_randonnee/).
On peut avoir un fichier de randos respectant ce schéma de données de randos sur d'autres plateformes open data, voir d'autres stockages de données standardisées.
Donc le parser devrait faire référence au schéma de données, mais pas à une des plateformes qui héberge des données respectant ce standard.

@babastienne
Copy link
Member

Donc le parser devrait faire référence au schéma de données, mais pas à une des plateformes qui héberge des données respectant ce standard.

Oui tu as raison. Là pour le moment la PR est en brouillon mais à terme l'idée n'est pas de référencer un flux issu de data gouv dans le code ni de considérer que c'est l'unique provenance de ces données. D'ailleurs le développement réalisé est prévu pour accueillir des données dans ce format mais pas du tout hébergées sur data gouv.

@camillemonchicourt
Copy link
Member

Oui oui OK, je parlais surtout du nom du parser.
OK on est d’accord.

@justinefricou justinefricou changed the title ✨ Add data gouv trek parser ✨ Add trek schema parser Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants