-
Notifications
You must be signed in to change notification settings - Fork 25
Pb 2295 GitHub actions #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
68d5f24 to
c6cdf98
Compare
- Install correct conda version - Run linux installation script
c592bd2 to
71371bf
Compare
dabd3b8 to
546fff7
Compare
6d46f52 to
5381c58
Compare
0d16d10 to
a3349b4
Compare
5a89bc4 to
c42e71d
Compare
20d51ba to
6b96adf
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
geojunky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Melyn, I've suggested a few minor tweaks. We're almost there.
tests/requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these requirements to conda_env_linux.sh as the final set of pip installs, so we can remove this requirements.txt altogether.
This reverts commit 9174465.
I removed the converagerc file as it was only including some directories to look at coverage for and excluding many others. I think it would be best to check coverage for the entire project. As I start increasing the coverage, I can build a new coveragerc if we feel it is necessary.
There are a lot of commits, but once this PR is approved and we're happy, I will squash and merge them.