Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize dask compute to avoid repeated load in wetland turbidity notebook #1240

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

uchchwhash
Copy link
Member

Proposed changes

Invoke dask compute at the opportune moment. Saves about 9mins of runtime for me. Uses about 500MB more memory.

Checklist

(Replace [ ] with [x] to check off)

  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@uchchwhash uchchwhash merged commit cd07472 into develop Jul 11, 2024
1 check passed
@uchchwhash uchchwhash deleted the ia/fix-wetland-turbidity-dask-issue branch July 11, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants