Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to ignore Markdown, RST and template and landing page notebooks #1194

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update ignored paths for tests
robbibt authored Feb 27, 2024
commit 523736f102ba2e5c96ff022a92f548e9ceec3d21
8 changes: 7 additions & 1 deletion .github/workflows/test_notebooks.yml
Original file line number Diff line number Diff line change
@@ -5,13 +5,19 @@ on:
push:
branches: [ develop, stable, nbtests ]
paths-ignore:
- '**/*.md' # ignore markdown files
- 'README.md' # ignore readme
- 'DEA_Sandbox.ipynb' # ignore landing page
- 'DEA_notebooks_template.ipynb' # ignore template
- '**/*.md' # ignore markdown files in nested folders
- '**/*.rst' # ignore restructured text files
- '.github/**' # ignore anything in .github folder
- '!.github/workflows/test_notebooks.yml' # except test_notebooks.yml
pull_request:
branches: [ develop, stable ]
paths-ignore:
- 'README.md'
- 'DEA_Sandbox.ipynb'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this should be ignored? It is a Notebook file that we need to check renders properly on the Sandbox.

Copy link
Member Author

@robbibt robbibt Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't actually include any code - it's all entirely pre-rendered markdown cells so there's not anything for pytest to run to test for a pass/fail.

- 'DEA_notebooks_template.ipynb'
- '**/*.md'
- '**/*.rst'
- '.github/**'