Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STAC doco #23

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Add STAC doco #23

merged 2 commits into from
Feb 14, 2022

Conversation

jmettes
Copy link
Member

@jmettes jmettes commented Feb 7, 2022

Added some information about accessing data using odc-stac. Reorganised the WMS/WCS stuff so it made more sense.

image

@jmettes
Copy link
Member Author

jmettes commented Feb 7, 2022

DE Africa has some more doco on using STAC without odc-stac, which might be worth including.

There also seems to be a QGIS plugin for STAC, which might be worth experimenting with and including.

Copy link
Collaborator

@CEKrause CEKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me (from a content point of view). I love that we have WCS documented now! There was a customer query just this morning that I can now point to this documentation to answer.

@robbibt
Copy link
Member

robbibt commented Feb 7, 2022

This looks fantastic! Two quick comments:

  • Can we spell out the acronym in the contents title to match the other listings? "SpatioTemporal Asset Catalogue (STAC)"
  • We do already have a STAC notebook in the User Guide, but it doesn't use odc-stac and is focused more on loading external data directly into the existing DEA environment (rather than loading DEA data into an external environment). In the future we can think about merging both of these - for now we perhaps might want to add a link at the bottom pointing to the existing notebook for people who want more info

@jmettes
Copy link
Member Author

jmettes commented Feb 7, 2022

@robbibt Yep, I agree. For now, I can link to the other non-odc-stac STAC page. I had thoughts about either:

  1. re-writing that page to be odc-stac only
  2. adding an 'exploration' section under the new page I added, to cover the workings of the API and metadata, etc.

Is odc-stac our recommended way for our users to interact with our STAC endpoint? Because that would be the perception, as the way the page is currently laid out now.

@CEKrause This is my first attempt at creating a section more focused on external access. I'll revisit this doco again once opendatacube/datacube-ows#798 has been released - I'll update the WCS doco on programmatic access.

@robbibt
Copy link
Member

robbibt commented Feb 7, 2022

@jmettes Is odc-stac our recommended way for our users to interact with our STAC endpoint? Because that would be the perception, as the way the page is currently laid out now.

That's an excellent question, and probably one for the DEA slack channel (or at least getting some other opinions in this thread). My feeling is probably "yes", assuming that odc-stac is definitely something that will see ongoing development? The code in this example is nice and simple which is good for a recommended method for accessing the data. The other notebook was written before odc-stac was a thing which explains some of the different methods used there - that said, some things like plotting up STAC results using geopandas is definitely very useful functionality that we will want to keep going forward regardless of how the data is loaded.

Two other quick thoughts that occurred to me since yesterday:

  • Should we add in !pip install pystac-client and !pip install odc-stac up the top of this guide to make it fully reproducible?
  • We should change resolution = 25 to resolution = 30 to reflect the new resolution of our Landsat Collection 3 data

@jmettes
Copy link
Member Author

jmettes commented Feb 9, 2022

Thanks for all the feedback @robbibt! I've added your suggestions.

@robbibt robbibt self-requested a review February 9, 2022 23:13
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmettes, looks great!

@jmettes jmettes merged commit 3b55134 into GeoscienceAustralia:master Feb 14, 2022
@jmettes jmettes deleted the stac-doco branch February 14, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants