Elevation and tide modelling improvements #72
Merged
+1,512
−2,520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some important fixes to both the elevation code and ensemble tide modelling code:
Elevation:
min_count
param that masks out any rolling median windows with less than N valid satellite observations. This greatly improves noise in the lower intertidalmin_periods
param and set sensible default to ensure the rolling mean smoother has enough data points for reliable results (also improves noise on lower intertidal)pixel_dem_debug
and intopixel_dem
so it only has to be maintained in one place, and made some assorted cleanups topixel_dem_debug
(before vs. after)
Tide modelling:
pixel_tides
orpixel_tides_ensemble
, thepixel_tides_ensemble
func has been updated to support both ensemble tide modelling and individual models (acting as a thin wrapper aroundpixel_tides
if a single model is provided). This greatly simplifies code and makes it harder for silly mistakes to creep in.pixel_tides_ensemble
has been updated to make sure important params likereduce_mean
andresolution
are actually passed through - this was silently failing before and we had no idea.Other:
exposure
script - this content is still available in theexposure_filters
branch, and removing it frommain
will make merging those changes much easier in the future.