Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation and tide modelling improvements #72

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Mar 7, 2024

Some important fixes to both the elevation code and ensemble tide modelling code:

Elevation:

  • Added a min_count param that masks out any rolling median windows with less than N valid satellite observations. This greatly improves noise in the lower intertidal
  • Added min_periods param and set sensible default to ensure the rolling mean smoother has enough data points for reliable results (also improves noise on lower intertidal)
  • Moved all elevation param logic out of pixel_dem_debug and into pixel_dem so it only has to be maintained in one place, and made some assorted cleanups to pixel_dem_debug

(before vs. after)

image

Tide modelling:

  • Rather than a big if/else that runs either pixel_tides or pixel_tides_ensemble, the pixel_tides_ensemble func has been updated to support both ensemble tide modelling and individual models (acting as a thin wrapper around pixel_tides if a single model is provided). This greatly simplifies code and makes it harder for silly mistakes to creep in.
  • pixel_tides_ensemble has been updated to make sure important params like reduce_mean and resolution are actually passed through - this was silently failing before and we had no idea.
  • Exposure and elevation code has been cleaned up to use the updated function

Other:

  • All notebooks updated
  • In-progress commented code temporarily removed from exposure script - this content is still available in the exposure_filters branch, and removing it from main will make merging those changes much easier in the future.

Copy link

github-actions bot commented Mar 7, 2024

For full integration test results, refer to the Tests directory README.

@robbibt robbibt changed the title DRAFT: Elevation improvements Elevation and tide modelling improvements Mar 8, 2024
@robbibt robbibt requested a review from vnewey March 8, 2024 04:14
Copy link
Collaborator

@vnewey vnewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Robbi!

@vnewey vnewey merged commit 878f343 into main Mar 8, 2024
@vnewey vnewey deleted the elevation_improvements branch March 8, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants