Update ancillary data loading functions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbibt
commented
Mar 4, 2024
| # Commit validation results produced by integration tests back into repo | ||
| - name: Commit validation results into repository | ||
| uses: stefanzweifel/git-auto-commit-action@v4 | ||
| if: github.event_name != 'release' | ||
| if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
This will hopefully prevent the workflow from commiting a second set of identical validation results when we merge PRs to main. Validation results should already have been committed to the PR branch before this point, so no need to do it twice.
robbibt
commented
Mar 4, 2024
| @@ -32,7 +32,7 @@ on: | |||
| - 'codecov.yaml' | |||
|
|
|||
| release: | |||
| types: [created, edited, published] | |||
| types: [edited, published] | |||
There was a problem hiding this comment.
Removing "created" so that the workflow doesn't run twice whenever we make a Github release (apparently every "published" release is also "created")
|
For full integration test results, refer to the Tests directory README. |
vnewey
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the two ancillary data loading functions
load_aclumandload_topobathyso that both functions now consistently return boolean mask array.In the case of
load_topobathy, this function now applies the elevation threshold internally, as well as an optional mask cleanup step that can be used to dilate the good data area (important to prevent losing good data in areas where the DEM is inaccurate).Have also updated the two notebooks, as well as a tiny change to prevent Github Actions from commiting validation results when we merge a PR to
main(this should have already happened on the branch during the pull request tests).