Fix compilation errors for rgeoda #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixun910
changed the title
Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
lixun910
commented
Jun 28, 2023
| : (unsigned long long)(((unsigned long long)nextLong() >> 32) * n) >> 32); | ||
| return r; | ||
| return r < 0 ? 0 : r; |
There was a problem hiding this comment.
@lixun910 Here the algorithm will return -1 in some cases, which is not correct. I need to check why this happens. But this should fix the issues that some functions calling nextInt() crashes rgeoda, see GeoDaCenter/rgeoda#39 GeoDaCenter/rgeoda#38 GeoDaCenter/rgeoda#33
lixun910
commented
Jun 28, 2023
| @@ -241,7 +241,7 @@ namespace ttmath | |||
| /*! | |||
| on 64bit platforms one word (uint, sint) will be equal 64bits | |||
| */ | |||
| typedef unsigned long uint; | |||
| typedef unsigned long long uint; | |||
There was a problem hiding this comment.
@lixun910 I should pay attention to this change:
unsigned long long is guaranteed to be at least 64 bits, regardless of the platform. unsigned long is guaranteed to be at least 32 bits.
There was a problem hiding this comment.
Anyway, this could be discarded by switching to boost::centroid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.