99 plot oc

[audreyyeoCH]

closes #99

ggsave() used to generate the snaps, just weird changes happening when svglite() used.

[github-actions]

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      166       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                71       5  92.96%   115-119
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  50       2  96.00%   94-95
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    24-101
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     2331     545  76.62%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/ocPostprob.R               0      -6  +5.13%
R/ocPredprob.R               0      -6  +2.93%
R/ocRctPostprobDist.R        0      -6  +3.61%
R/ocRctPredprobDist.R        0     -60  +19.87%
R/plotOc.R                 +29     -19  +96.00%
TOTAL                      +29     -97  +4.51%

Results for commit: df86400

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

    1 files     17 suites   7m 13s ⏱️
  129 tests   128 ✅ 1 💤 0 ❌
1 287 runs  1 284 ✅ 3 💤 0 ❌

Results for commit df86400.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
ocPredprobDist	💔	$165.28$	$+3.94$	$0$	$0$	$0$	$0$
plotOc	💔	$101.84$	$+102.78$	$+5$	$+2$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
ocPredprobDist	💔	$44.65$	$+1.15$	ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_TRUE
ocPredprobDist	💔	$58.33$	$+1.42$	ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
plotOc	💔	$53.48$	$+1.35$	h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc	👶		$+0.31$	plotOc_gives_expected_results_for_ocPostprob_and_ocPredprob_
plotOc	👶		$+100.63$	plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status

Results for commit 272f95c

♻️ This comment has been updated with latest results.

[danielinteractive]

almost there, thanks @audreyyeoCH

[audreyyeoCH]

Adding here for later ref, current RCMD issue for pipe not found even though magrittr and dplyr imported from DESCRIPTION file. Ref'ed solution not current solution but closest.

[audreyyeoCH]

Hi @danielinteractive would you mind checking out this persisted R CMD check error ? The log keeps saying :

Error in df %>% dplyr::group_by(deci
sion, look) %>% dplyr::summarise(prop = sum(length(decision))/nrow(df)) %>% :
could not find function "%>%"

I've changed the pipe to baseR's |>, something seems off, the tests are also failing on a local R CMD check, another thing to deal with even though the tests look like they passed here.

Here's the perma link

Edit also this error related to a helper function that isn't related to this PR, it passed last time

[danielinteractive]

Hi @audreyyeoCH , I just checked the check log and it failed due to a warning:

Undocumented arguments in Rd file 'plotOc.Rd': ‘sample_size’

Otherwise it is actually ok.

That said, it would be good if you can also address the notes that are reported in there, maybe in a separate PR.

[audreyyeoCH]

Hi @audreyyeoCH , I just checked the check log and it failed due to a warning:

Undocumented arguments in Rd file 'plotOc.Rd': ‘sample_size’

Otherwise it is actually ok.

That said, it would be good if you can also address the notes that are reported in there, maybe in a separate PR.

thanks for looking @danielinteractive

I think I will open another PR, as I need to use Design doc again

[danielinteractive]

I think good to merge, thanks @audreyyeoCH