Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help-url for Allowed Values #1146

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update help-url for Allowed Values #1146

merged 1 commit into from
Feb 5, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Feb 4, 2025

Committer Notes

Purpose

This PR aims to update the help-url links for the allowed values constraints to align with the change in documentation structure.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner February 4, 2025 14:57
@Gabeblis Gabeblis linked an issue Feb 4, 2025 that may be closed by this pull request
Update help-url in fedramp-external-allowed-values #1134
Open
7 tasks
@Gabeblis Gabeblis self-assigned this Feb 4, 2025
wandmagic
wandmagic approved these changes Feb 4, 2025
View reviewed changes
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we are talking, i like this!

@aj-stein-gsa aj-stein-gsa merged commit bd8eacb into GSA:develop Feb 5, 2025
6 checks passed
Gabeblis added a commit to Gabeblis/fedramp-automation that referenced this pull request Feb 5, 2025
@Gabeblis
Revert "Update help url for allowed values (GSA#1146)"
5dbeeee 
This reverts commit bd8eacb.
@Gabeblis Gabeblis removed a link to an issue Feb 7, 2025
Update help-url in fedramp-external-allowed-values #1134
Open
7 tasks
Gabeblis added a commit to Gabeblis/fedramp-automation that referenced this pull request Feb 12, 2025
@Gabeblis
Revert "Update help url for allowed values (GSA#1146)"
707954c 
This reverts commit bd8eacb.
aj-stein-gsa pushed a commit that referenced this pull request Feb 12, 2025
@Gabeblis
Revert "Update help url for allowed values (#1146)" (#1152)
f493e85 
* Revert "Update help url for allowed values (#1146)"

This reverts commit bd8eacb.

* Remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wandmagic wandmagic wandmagic approved these changes

@aj-stein-gsa aj-stein-gsa aj-stein-gsa approved these changes

Assignees

@Gabeblis Gabeblis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabeblis @wandmagic @aj-stein-gsa