-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inventory-item-or-component-has-network
constraint
#1065
base: canary
Are you sure you want to change the base?
Conversation
@Rene2mt As of right now, upstream allowed-values don't allow for a "ipv4-address", "ipv6-address", "fqdn", or "uri" prop in an internal service component. This constraint is blocked. |
unfortunate we can't add them in? how can we get unblocked here? |
7c62301
to
1765b26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constraint looks good, we can keep it in canary while its blocked upstream
72740ed
to
9cf0c60
Compare
9cf0c60
to
85e8c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
Committer Notes
Purpose
This PR aims to add the
inventory-item-or-component-has-network
constraint which ensures that each inventory item or internal service component is reachable via a network, which requires either an IPv4 address, IPv6 address, fully qualified domain name (FQDN) or uniform resource identifier (URI).Changes
Added constraint:
inventory-item-or-component-has-network
Added valid/invalid test content:
ssp-inventory-item-or-component-has-network-INVALID.xml
fedramp-ssp-example.oscal.xml
to align with constraintAdded yaml files for testing:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.