cleanup GUI special member functions #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tidy checks had a large impact: cppcoreguidelines-prefer-member-initializer modernize-use-default-member-init modernize-use-equals-default Some instances of other tidy issues were resolved: clang-analyzer-optin.cplusplus.VirtualCall cppcoreguidelines-special-member-functions readability-inconsistent-declaration-parameter-name readability-named-parameter and others. Overall we have 1334 fewer tidy checks on our code base, a reduction of 15% of the total! The user defined dtor for class SettingGroup was eliminated by using std::vector<std::unique_ptr<VarSetting>> instead of a QList of raw pointers. The user defined dtor for class FilterWidget was eliminated by using std::vector<std::unique_ptr<FilterOption>> instead of a QList of raw pointers.
robertlipe
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Awesome. The GUI has been kind of a pre-C++11 time capsule for a long time. That's a direct artifact of how well the original code has just worked - we've not HAD to look at it much, so we've not been annoyed enough by it to "fix" it. :-)
Good problems to have, in a way.
|
This resolves #573 |
|
This closes #687, which accomplished a subset of what this PR included. |
This was referenced Nov 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tidy checks had a large impact:
cppcoreguidelines-prefer-member-initializer
modernize-use-default-member-init
modernize-use-equals-default
Some instances of other tidy issues were resolved:
clang-analyzer-optin.cplusplus.VirtualCall
cppcoreguidelines-special-member-functions
readability-inconsistent-declaration-parameter-name
readability-named-parameter
and others.
Overall we have 1334 fewer tidy checks on our code base, a
reduction of 15% of the total!
The user defined dtor for class SettingGroup was eliminated
by using std::vector<std::unique_ptr> instead of a
QList of raw pointers.
The user defined dtor for class FilterWidget was eliminated
by using std::vector<std::unique_ptr> instead of a
QList of raw pointers.