fix SchemaArrayField/SchemaArrayData mismatch #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to IGC additions from GPSBabel#1060 and GPSBabel#1054.
|
@PacketFiend this does not differ from tsteven4:kmlaccumulate you looked at yesterday, but the history reflects the merge of #1060. It is a draft as I want to clean things up a bit. |
|
@robertlipe I intend to remove global_trait traits. The only usage was kml, and the kml usage for multitrack is specific only to track points or, for geoache, only to waypoints. |
|
I've lost the beat (traveling/vacation) but the reason I added the 'traits'
stuff was so that we could amortize the cost of figuring out what kind of
stuff we have that might require a preamble during add instead of making a
pass over the entire waypoint/track list. That was we could decide whether
to write the geocache or track template in the KML header
without actually scanning the whole list to find the presence/absence of
these things.
If you've found a way around this that's performant enough to meet your
high standards, I won't weep.
RJL
…On Thu, Sep 14, 2023 at 7:54 AM tsteven4 ***@***.***> wrote:
Merged #1177 <#1177> into master.
—
Reply to this email directly, view it on GitHub
<#1177 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3VAD3YQKA4GJTM6UJWC6TX2L5BXANCNFSM6AAAAAA4UYKBYM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to IGC additions from #1060 and #1054.