Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaound curl bug in lastest windows github runner. #1111

Merged
merged 2 commits into from
May 14, 2023

Conversation

tsteven4
Copy link
Collaborator

workaround actions/runner-images#7329 which was causing windows build to fail to upload the installer to the continuous release.

@GPSBabelDeveloper GPSBabelDeveloper self-requested a review May 14, 2023 18:17
@GPSBabelDeveloper
Copy link
Collaborator

LGTM

Nice find.

@tsteven4
Copy link
Collaborator Author

How about the continuous release for Linux of a snap? It's already been used by a problem reporter to verify his fix. We seem to be getting a rash of osm format issues, and the reporters seem to be on ubuntu.

@tsteven4 tsteven4 merged commit 3bc6567 into GPSBabel:master May 14, 2023
@tsteven4 tsteven4 deleted the curlbug branch May 14, 2023 18:45
@robertlipe
Copy link
Collaborator

robertlipe commented May 14, 2023 via email

@tsteven4
Copy link
Collaborator Author

This is my third try or so with snapcraft, over many years. The first two flamed out, but this time the CLI came together almost at once. I think having a Linux installer is useful. A number of recent problems were reported on Linux, and it is a burden that may not be overcome to ask the reporter to build gpsbabel from source to verify a fix. In one instance the reporter built from source, in the other I got the snap online before they were able to build from source, and they used the snap to verify the fix. If the reporter isn't regularly building gpsbabel then it is much easier to use the snap built by CI.

The GUI is more complicated than our CLI as it uses plugins. I eventually learned enough to get by this. But QWebEngine adds another layer that I haven't conquered yet. In any event, for testing a pre-release the CLI is likely what all we need. Let's see how that flies.

BTW the snap should portable, a single snap should be usable on not just multiple versions of Ubuntu, but Debian, Fedora, Arch, and more.

@robertlipe
Copy link
Collaborator

robertlipe commented May 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants