Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GT-181] Add last logged in field for admins #477

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Sep 8, 2023

[Functionality]

To help with user support when someone queries one of the account deletion emails, it would be useful to be able to see when the account was last logged in to in the web interface.

"Resolves #456 ".

@Sae126V Sae126V requested a review from a team as a code owner September 8, 2023 09:35
@Sae126V Sae126V force-pushed the GT-181-(F)-Show-last-login-on-user-pages-to-admins branch from 33df486 to bb6a099 Compare September 8, 2023 13:13
@Sae126V
Copy link
Contributor Author

Sae126V commented Sep 8, 2023

Ready to be reviewed.

@gregcorbett
Copy link
Member

Looks good to me.

There's a slight issue with the colour of the rows if a User doesn't have a Home Site (I forgot this was a thing and it is being removed from GOCDB #266), however this is probably easiest to fixed as part of the wider refatoring to how the colour of the rows is decided.

image

vs

image

I've opened #478 to track this.

@gregcorbett
Copy link
Member

rebasing on top of latest dev

@gregcorbett gregcorbett force-pushed the GT-181-(F)-Show-last-login-on-user-pages-to-admins branch from bb6a099 to 3fb6c54 Compare September 11, 2023 10:35
@gregcorbett gregcorbett self-assigned this Sep 11, 2023
@gregcorbett gregcorbett added this to the May 2023 milestone Sep 11, 2023
@gregcorbett gregcorbett merged commit 574f1ea into GOCDB:dev Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show last login on user pages to admins
3 participants