GT-95 Softcoding of service type production<=>monitored service flag relations. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRyall
reviewed
Mar 11, 2020
|
I was unable to replicate the schema update problem I ran into originally, so have reverted to suggested definition - which was what I first had afaiks :-( |
ghost
marked this pull request as ready for review
gregcorbett
added
the
schema change
gregcorbett
reviewed
Feb 6, 2023
gregcorbett
requested changes
Feb 6, 2023
tofu-rocketry
changed the title
gregcorbett
previously approved these changes
Mar 24, 2023
|
rebasing on top of latest dev |
added 2 commits
March 24, 2023 10:55
Add monitoring-exception-allowed flag to service type table, associated GUI changes and cleanups. Add instance count column to service type overview table.
Sae126V
reviewed
Mar 24, 2023
Sae126V
reviewed
Mar 24, 2023
Sae126V
reviewed
Mar 24, 2023
Sae126V
reviewed
Mar 24, 2023
- If you line break in a string, the whitespace is taken literally - as such, the whitespace was appearing in the link to the ServiceType - the link still worked, but it seemed slow to respond.
gregcorbett
dismissed
their stale review
going to do some final testing before merging.
gregcorbett
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft pull request while doctrine schema update issues are checked and resolved.
Add monitoring-exception-allowed flag to service type table.
Associated GUI changes and cleanups.
Add instance count column to service type overview table.
Add related unit tests.
Closes #156