Adjust path for wheels to upload and logic for detecting when to use …

…pre-built Linux binaries
GMLC-TDC · Feb 3, 2024 · ef546c1 · ef546c1
1 parent 4875b20
commit ef546c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
@@ -71,7 +71,7 @@ jobs:
     - uses: actions/upload-artifact@v4
       with:
         name: apps-python-dist-${{matrix.artifact_suffix}}
-        path: helics_apps-pip/wheelhouse/*.whl
+        path: wheelhouse/*.whl
 
   build-helics_apps-sdist:
     runs-on: ubuntu-latest
@@ -81,9 +81,8 @@ jobs:
         fetch-depth: 0  # for setuptools_scm to find tags
 
     - name: Build sdist
-      run: |
-        cd ./helics_apps-pip
-        pipx run build --sdist
+      working-directory: helics_apps-pip
+      run: pipx run build --sdist
 
     - name: Upload artifacts
       uses: actions/upload-artifact@v4

diff --git a/helics_apps-pip/CMakeLists.txt b/helics_apps-pip/CMakeLists.txt
@@ -7,7 +7,7 @@ include(FetchContent)
 
 # Note: Linux requires a hint for whether this wheel should be for manylinux (glibc) or musllinux
 # -- The CIBW_ARTIFACT_TYPE environment variable is only expected to be set during official release builds using cibuildwheel on GHA CI systems
-if(LINUX AND CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" AND ENV{CIBW_ARTIFACT_TYPE} STREQUAL "manylinux_x86_64")
+if(LINUX AND CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" AND "$ENV{CIBW_ARTIFACT_TYPE}" STREQUAL "manylinux_x86_64")
     set(HELICS_DOWNLOAD_URL https://github.com/GMLC-TDC/HELICS/releases/download/v${SKBUILD_PROJECT_VERSION}/Helics-${SKBUILD_PROJECT_VERSION}-Linux-x86_64.tar.gz)
 elseif(APPLE AND CMAKE_SYSTEM_NAME STREQUAL "Darwin")
     set(HELICS_DOWNLOAD_URL https://github.com/GMLC-TDC/HELICS/releases/download/v${SKBUILD_PROJECT_VERSION}/Helics-${SKBUILD_PROJECT_VERSION}-macOS-universal2.zip)