update the command line output to behave better #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This was referenced Jan 17, 2025
|
|
|
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@trevorhardy can you check this again? |
|
Pulled down the new commits (7fbb609) and |
phlptp
force-pushed
the
output_control
branch
from
7753a71 to
88903f8
Compare
for more information, see https://pre-commit.ci
|
@trevorhardy try again? |
|
@phlptp, no luck. The clone output JSON does now have |
|
@trevorhardy try again? |
for more information, see https://pre-commit.ci
|
That did it! This is the clone output: |
trevorhardy
approved these changes
Feb 14, 2025
|
Fixes #2731 |
nightlark
reviewed
Feb 14, 2025
nightlark
reviewed
Feb 14, 2025
nightlark
reviewed
Feb 14, 2025
| opt->check([](const std::string& fname) { | ||
| static const std::set<std::string> validExt = { | ||
| ".ini", ".toml", ".json", ".INI", ".JSON", ".TOML"}; | ||
| auto ext = std::filesystem::path(fname).extension().string(); |
There was a problem hiding this comment.
Should we just make the extension lowercase, so we only need to list one variant in the list of valid extensions?
There was a problem hiding this comment.
I thought about that but it seemed like it would be more efficient to just let the set deal with it, rather than call an additional function every time. I tried routing it through the CLI validator that does that but it had some annoying side effects so I went away from that option.
Co-authored-by: Ryan Mast <[email protected]>
nightlark
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will adjust the output flag for recorders/clone and add capture flag for clone
Proposed changes