Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: model test updates #441

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

wip: model test updates #441

wants to merge 28 commits into from

Conversation

kirstybayliss
Copy link
Contributor

@kirstybayliss kirstybayliss commented Oct 31, 2024

This PR includes:

  • updates to the descriptions of completeness norms and optimise criteria
  • source_tests updates to work with point sources and to run for a whole folder
  • updates on homogenisation (cat) and sub documentation
  • added warnings to workflow when small catalogues are used
  • adding a required sourceConverter object when merging fault and point sources
  • passing on correct source names when removing fault buffers from multipoint sources
  • passing sigma values from weichert_analysis to the toml file outputs when making sources
  • some general tidying

wip because I apparently tried to add the option to set binwidths in the completeness fitting but I did not implement this properly, and in fact implementing this change requires some more substantial changes to the norm calculations. This only affects the optimise norm option, and only if you try to use this branch (previous version is fine, it just doesn't let you choose the binwidth). This is (at least partly) why this is currently failing.

@kirstybayliss kirstybayliss marked this pull request as draft October 31, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant