Replace trace serialization from proto to json #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladjan-gadzic
commented
May 16, 2025
mladjan-gadzic
commented
May 16, 2025
| serialized_traces_data = traces_data.SerializeToString() | ||
| serialized_traces_data = json_format.MessageToJson(traces_data) | ||
|
|
||
| # FIXME/HACK replace serialized traceId and spanId values as string comparison |
There was a problem hiding this comment.
not the happiest solution but built-in json serialization does not serialize trace_id and span_id from span according to partial collector expectations.
There was a problem hiding this comment.
still, i prefer this over manual serialization where a lot of things can be missed/go wrong.
There was a problem hiding this comment.
adding a test for a hack seems silly to me since this is using built-in json serialization.
jgiannuzzi
reviewed
May 16, 2025
Co-authored-by: Jonathan Giannuzzi <[email protected]>
jgiannuzzi
approved these changes
May 19, 2025
mladjan-gadzic
deleted the
no-ticket-replace-proto-serialization-with-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.