feature: added listing exported services functionality #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Consul | ||
| { | ||
| public class ServiceConsumer |
Contributor
There was a problem hiding this comment.
I would be in favor of keeping the class names close to the original definitions from consul -> https://github.com/hashicorp/consul/blob/159d7a61f268e8d50a51466b5de56eec49866d3f/api/exported_services.go#L6C6-L24
| var cutOffVersion = SemanticVersion.Parse("1.17.3"); | ||
| Skip.If(AgentVersion < cutOffVersion, $"Current version is {AgentVersion}, but this test is only supported from Consul {cutOffVersion}"); | ||
| var result = await _client.ExportedServices.ListExportedService(); | ||
| Assert.NotNull(result.Response); |
Contributor
There was a problem hiding this comment.
Can we be more strict with checks here (e.g., the returned list is not empty, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for listing exported services in Consul and the following changes were made:
Added ServiceConsumer model.
Implemented the PeeringList method to handle the request GET /v1/exported-services.
Added a test ExportedServicesTest_ListExportedServices to validate changes.
Related Issues
Additional Context
Addresses issue #529
Checklist
Please make sure to check the following before submitting your pull request: