Build: Fix file version not set properly on DLL (#113)

Co-authored-by: Marcin Krystianc <[email protected]> Co-authored-by: Jonathan Giannuzzi <[email protected]>
G-Research · Aug 4, 2021 · 5d63379 · 5d63379
1 parent 32fc634
commit 5d63379
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 57 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Unreleased
+* Fix DLL versioning showing 0.0.0.0 (#112)
 
 ## 1.6.10.2
 * Add support for net5.0 (#85).

diff --git a/Consul.Test/Properties/AssemblyInfo.cs b/Consul.Test/Properties/AssemblyInfo.cs
diff --git a/Consul/Consul.csproj b/Consul/Consul.csproj
@@ -3,8 +3,11 @@
  <PropertyGroup>
  <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
  <Authors>PlayFab,$(Authors)</Authors>
+ <Copyright>Copyright 2015-2018 PlayFab Inc.; $(Copyright)</Copyright>
  <Description>Consul.NET is a .NET client library for the Consul HTTP API</Description>
  <PackageOutputPath>../dist/consul</PackageOutputPath>
+ <AssemblyTitle>Consul.NET</AssemblyTitle>
+ <AssemblyProduct>Consul.NET</AssemblyProduct>
  </PropertyGroup>
 
  <ItemGroup>

diff --git a/Consul/Properties/AssemblyInfo.cs b/Consul/Properties/AssemblyInfo.cs
@@ -1,18 +1,5 @@
-using System.Reflection;
 using System.Runtime.CompilerServices;
 
-// General Information about an assembly is controlled through the following
-// set of attributes. Change these attribute values to modify the information
-// associated with an assembly.
-[assembly: AssemblyTitle("Consul.NET")]
-[assembly: AssemblyDescription(".NET API for Consul (http://www.consul.io/)")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("G-Research Limited")]
-[assembly: AssemblyProduct("Consul.NET")]
-[assembly: AssemblyCopyright("Copyright 2015 PlayFab, Inc.; Copyright 2020 G-Research Limited")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
-
 [assembly: InternalsVisibleTo("Consul.Test, PublicKey=" +
  "002400000480000094000000060200000024000052534131000400000100010045f6337bf03a95" +
  "218f1e0b4e70bb91f8ee49fcb58593d78c1008ee646cfcf785ea60bd0b1dde6f5f92ead738e2bd" +

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -9,9 +9,9 @@
  <RepositoryType>git</RepositoryType>
  <RepositoryUrl>https://github.com/G-Research/consuldotnet</RepositoryUrl>
  <Authors>G-Research</Authors>
- <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
  <PublicSign>true</PublicSign>
  <AssemblyOriginatorKeyFile>../assets/consuldotnet.snk</AssemblyOriginatorKeyFile>
  <SignAssembly>true</SignAssembly>
+ <Copyright>Copyright 2020-$([System.DateTime]::Now.ToString('yyyy')) G-Research Limited</Copyright>
  </PropertyGroup>
-</Project>
+</Project>