Fix out of memory errors causing logic_error when using ManagedRandomAccessFile#471
Merged
Merged
Conversation
4837cd1 to
d0fcd8b
Compare
marcin-krystianc
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one of the
ManagedRandomAccessFilemethods called from C++ caused anOutOfMemoryException, the exception message was set tonullinHandleException, but this caused astd::logic_erroron the C++ side when trying to convertnullptrtostd::stringwhen constructing anarrow::StatusinManagedRandomAccessFile::GetResult. The error looks like:I've added a check for
exception == nullptrto fix this.I've also changed the
TRYCATCHmacro so that these errors are propagated out as anOutOfMemoryExceptionagain, and fixed the use of plain integers for status codes.