Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.cfg metadata #552

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

h-mayorquin
Copy link
Contributor

Hey guys, specifying metadata with dashes is deprecated on the last version of setuptools:

https://setuptools.pypa.io/en/stable/history.html?utm_source=chatgpt.com#bugfixes

This is causing people that want to build your package using the latest version of setuptools to fail:

NeuralEnsemble/python-neo#1660 (comment)

This PR should fix it.

@h-mayorquin
Copy link
Contributor Author

It seems they did another release that postpones this but it is still a good idea to move forward with this.

@h-mayorquin
Copy link
Contributor Author

This should fix #551 I think.

@coveralls
Copy link

Coverage Status

coverage: 78.571%. remained the same
when pulling fa7eb9f on h-mayorquin:fix_setup_metadata
into 96271f1 on G-Node:master.

@jgrewe
Copy link
Member

jgrewe commented Mar 25, 2025

@h-mayorquin thank you

@jgrewe jgrewe merged commit 80d2df2 into G-Node:master Mar 25, 2025
21 checks passed
@h-mayorquin h-mayorquin deleted the fix_setup_metadata branch March 25, 2025 17:01
@h-mayorquin
Copy link
Contributor Author

Thanks for the merge.

Btw, reading about this yesterday I realized that description_file is not even a valid metadata field. I think the correct field is long_description. Apparently, someone used it at some point and people have been copying it from other setup-like configurations but the correct

I suggest a move to pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants