Cloud provisioning + QoL #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configuration
Co-authored-by: Cappy Ishihara <[email protected]>
Into<ExitNode> conversion
Co-authored-by: lleyton <[email protected]>
korewaChino
requested review from
korewaChino
and removed request for
korewaChino
lleyton
commented
Jan 20, 2024
|
|
||
| info!("Created instance: {:?}", instance); | ||
|
|
||
| let instance_ip = loop { |
There was a problem hiding this comment.
while these loops are okay for now, this isn't a reliable solution that we want to keep for long
we should ideally have an "ip acquiring" state on the ExitNode, and have a single loop in the operator that polls the relevant provider for matched ExitNodes
that way, if the operator crashes while this wait is happening, we can resume from where we left off, with the node we already created with the provider, otherwise there's the chance that we may leave a random dangling node
| @@ -0,0 +1,41 @@ | |||
| pub fn generate_cloud_init_config(password: &str, port: u16) -> String { | |||
| let cloud_config = serde_json::json!({ | |||
| "runcmd": ["curl https://i.jpillora.com/chisel! | bash", "systemctl enable --now chisel"], | |||
There was a problem hiding this comment.
sometimes I wish we had our own image... but maintaining images for all of these stupid cloud providers is.. yeah
basically all of the logic is now in a chisel_operator lib target, which our entrypoints import from this gets rust_analyzer to handle the dead code warnings properly
|
what's left for this to be merged |
|
see: #7 (comment) wanted to discuss with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.