Added ability to limit the LoadBalancers picked up by chisel-operator #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove duplicate `serviceAccountName` key
|
did i just get nerd sniped |
yea |
korewaChino
requested changes
Jan 8, 2025
|
|
||
| // Check if the REQUIRE_OPERATOR_CLASS environment variable is set | ||
| let limit_load_balancer_class; | ||
| match env::var("REQUIRE_OPERATOR_CLASS") { |
There was a problem hiding this comment.
REQUIRE_OPERATOR_CLASS's envar key should be a const in case the name needs to be changed, so one can easily change them in case it does need to be changed
| let limit_load_balancer_class; | ||
| match env::var("REQUIRE_OPERATOR_CLASS") { | ||
| Ok(v) => limit_load_balancer_class = v, | ||
| Err(_e) => limit_load_balancer_class = "false".to_string(), |
There was a problem hiding this comment.
This could be a bit more elegant by using unwrap_or_else instead of a named block
| .as_ref() | ||
| .filter(|spec| { | ||
| spec.load_balancer_class.is_none() | ||
| (spec.load_balancer_class.is_none() && ( limit_load_balancer_class == "false")) |
There was a problem hiding this comment.
You could also cast the boolean to a string using FromStr
|
Oops, I forgot to submit my review :P |
|
Could you please update this PR? Rebase it to the latest branch |
|
superceded by #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured this locally and noticed @xyhhx has created a request for the capability - #150
Uses an environment variable REQUIRE_OPERATOR_CLASS to determine whether the LoadBalancers picked up by chisel-operator should be limited.
Includes configuration updates for the helm chart