Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the datastructure for external dependencies in the namespace module #7039

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Mar 25, 2025

Description

Fixes #6838 .

Status:

  • Introduced Project struct
  • Moved externals from Package to Project
  • Introduce mapping from Forc.toml dependencies section to Package
  • Updated most access functions in namespace.rs, package.rs, project.rs

TODO:

  • Fix commented-out functions in namespace.rs
  • Update contract_helpers.rs
  • Update calls to functions in namespace module
  • Update forc-pkg to create and supply Project struct instead of Package struct
  • Remove Clone attribute from Package and Module, possibly TraitMap
  • Update sway-lsp and other tooling to use Project instead of Package

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Represent external bindings as a dag rather than as a tree
1 participant