Cleanup stale lock files in the .lsp-locks directory #6816

JoshuaBatty · 2025-01-06T23:33:38Z

Description

I noticed there were quite a few old stale lock files in the .lsp-locks directory. We now check that the PID is active for each file in this directory, if it's not active then it's removed.

Checklist

I have linked to any relevant issues.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- If my change requires substantial documentation changes, I have requested support from the DevRel team
I have added tests that prove my fix is effective or that my feature works.
I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
I have requested a review from the relevant team or maintainers.

…tory

forc-util/src/fs_locking.rs

zees-dev

Left a few optional minor improvements (maybe opinionated here); nothing major - feel free to use them 😄
LGTM 👍

forc-util/src/fs_locking.rs

kayagokalp · 2025-01-07T14:14:55Z

This made me check the forc locks and same thing happens there too, without any active forc process I have more than 50 locks in ~/.forc/.locks 🤯

edit: opened #6818

tritao · 2025-03-30T16:38:35Z

New test seems to be flakey, getting some failures in CI:

---- fs_locking::test::test_cleanup_stale_files stdout ----

thread 'fs_locking::test::test_cleanup_stale_files' panicked at forc-util/src/fs_locking.rs:266:9:
assertion `left == right` failed
  left: 0
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

## Description I noticed there were quite a few old stale lock files in the `.lsp-locks` directory. We now check that the PID is active for each file in this directory, if it's not active then it's removed. ## Checklist - [ ] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: Sophie Dankel <[email protected]>

…s` crate (#7055) ## Description adds the mark-flaky-tests crate so we can use `#[flaky]` above tests that might fail. Also improves the `test_cleanup_stale_files` test which was added in #6816 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

Add functionality to cleanup stale lock files in the .lsp-locks direc…

f466d4c

…tory

JoshuaBatty requested a review from a team as a code owner January 6, 2025 23:33

JoshuaBatty self-assigned this Jan 6, 2025

JoshuaBatty added the language server LSP server label Jan 6, 2025

zees-dev reviewed Jan 6, 2025

View reviewed changes