-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: front-end optimisation strategies #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
danielbate
wants to merge
73
commits into
st/feat/assemble-tx
from
db/feat/connector-before-estimation
Closed
feat: front-end optimisation strategies #3769
danielbate
wants to merge
73
commits into
st/feat/assemble-tx
from
db/feat/connector-before-estimation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implement flags for the transaction request * chore: combine flags for `isEstimated` and `isFunded` * chore: remove `isSigned` from witness updates * changeset * revert experimental changes * Aligned to the new re-spec * update to state * Update state * chore: fix connector test * lintfix * Apply suggestions from code review
* chore: moved chainInfo serialization * chore: added serialize chain info * move chain info helper * add deprecation notice * chore: added deserialize of nodeInfo * Added the ability to restore the provider chain + node info cache * consolidate serialization * serialize provider cache * pass serialized chain to connector * lintfix * lintfix * changeset * changeset * lintfix
…proved-sdk-wallet-communication
…proved-sdk-wallet-communication
Contributor
|
Coverage Report:
Changed Files:
|
Contributor
|
Closing in favor of [the upcoming]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
onBeforeAssembleTxhook to wallet connectors for quicker estimationSummary
This PR introduces two approaches to enable more optimal transaction speeds from estimation to summary generation:
Connector Aware Estimation
Adds the
onBeforeAssembleTxfunction to the connector interface. This allows for connector specific modifications to a transaction request to be added before the SDK assembles the transaction. A specific use case for this is the SVM/EVM connectors that fund a transaction using an associated predicate account.Inverted Submission Flow
Utilises the change made to the
connector.sendTransaction()signature in #3669 whereby we can now return astring | TransactionResponse.fuels-ts/packages/account/src/connectors/fuel-connector.ts
Lines 47 to 51 in e8494fa
This approach enables #3665 to allow connector transactions to submit and generate a transaction summary in apps in a single request.
Proof Of Concept
A demo using the above approaches can be seen in the connectors repo here. The result of which can be seen here:
Screen.Recording.2025-03-21.at.12.10.52.mov
Checklist