-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: made ResourceCache
consider resource owner
#3697
base: st/chore/[email protected]
Are you sure you want to change the base?
chore!: made ResourceCache
consider resource owner
#3697
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ResourceCache
consider resource ownerResourceCache
consider resource owner
…esource-cache-owner-specific
if (cached.utxos.length || cached.messages.length) { | ||
const { | ||
consensusParameters: { | ||
txParameters: { maxInputs }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we questions the client team about using the maxInputs
as the configurable for the maximum number of excludedIds
?
This could become an issue when attempting to consolidate UTXOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nedsalk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintfix needed.
…esource-cache-owner-specific
Coverage Report:
Changed Files:
|
ResourceCache
Owner-Aware #3696Summary
This PR addresses 2 things:
1 - Resources IDs are now cached considering their owner.
2 - A check has been added to prevent
Provider.getResourcesToSpend
from being called with more cached resource IDs than themax_inputs
value.Breaking Changes
Checklist