-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fault_proving(compression): compute registry root #2732
base: chore/impl-temporal-registry-for-v2-tables
Are you sure you want to change the base?
fault_proving(compression): compute registry root #2732
Conversation
1715dd6
to
7cb4ae9
Compare
b0cddce
to
5b2feba
Compare
5befcaa
to
e1e7832
Compare
5b2feba
to
bf6973a
Compare
a159a27
to
be1ea4c
Compare
e1e7832
to
63c9a54
Compare
acd9039
to
508d189
Compare
508d189
to
0d40246
Compare
0d40246
to
118ba9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Some thoughts and comments. Only blocker is the .unwrap_or(...default())
which at least should be unwrap_or_default
, but I'd like to see an error there instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Warning
please dont merge/rebase. PR not based on master.
Linked Issues/PRs
part 3/3 of #2568
closes #2568
Description
Updates the compression crate to include registry root handling.
Feature flag implementation:
crates/compression/src/compress.rs
: Added conditional compilation blocks to defineCompressDb
traits and implementations based on the "fault-proving" feature.crates/compression/src/ports.rs
: Introduced theRegistryRootGetter
trait for retrieving the registry root, with implementations conditioned on the "fault-proving" feature.Registry root handling:
crates/compression/src/compressed_block_payload/v1.rs
: ModifiedCompressedBlockHeader
to include aregistry_root
field and updated related methods to handle this field. [1] [2] [3]crates/compression/src/lib.rs
: UpdatedVersionedCompressedBlock
to include theregistry_root
when the "fault-proving" feature is enabled. [1] [2]Tests:
crates/compression/src/lib.rs
: Enhanced tests to verify the inclusion of theregistry_root
inCompressedBlockHeader
when the "fault-proving" feature is enabled. [1] [2] [3]Additional changes:
crates/fuel-core/src/graphql_api/da_compression.rs
: Implemented theRegistryRootGetter
trait forCompressDbTx
to support registry root retrieval.crates/fuel-core/src/graphql_api/ports.rs
: Addedregistry_root
method to theDatabaseTransaction
trait under the "fault-proving" feature.crates/fuel-core/src/graphql_api/storage.rs
: Implemented theregistry_root
method to compute the root hash of various merkle trees in the temporal registry.Note
we also add
fault-proving
feature to the integ tests, as well as ci target for itChecklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]