Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault_proving(compression): compute registry root #2732

Open
wants to merge 3 commits into
base: chore/impl-temporal-registry-for-v2-tables
Choose a base branch
from

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Feb 20, 2025

Warning

please dont merge/rebase. PR not based on master.

Linked Issues/PRs

part 3/3 of #2568

closes #2568

Description

Updates the compression crate to include registry root handling.

Feature flag implementation:

  • crates/compression/src/compress.rs: Added conditional compilation blocks to define CompressDb traits and implementations based on the "fault-proving" feature.
  • crates/compression/src/ports.rs: Introduced the RegistryRootGetter trait for retrieving the registry root, with implementations conditioned on the "fault-proving" feature.

Registry root handling:

Tests:

Additional changes:

Note

we also add fault-proving feature to the integ tests, as well as ci target for it

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc self-assigned this Feb 20, 2025
@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Feb 20, 2025
@rymnc rymnc force-pushed the chore/impl-temporal-registry-for-v2-tables branch from 1715dd6 to 7cb4ae9 Compare February 20, 2025 10:58
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch from b0cddce to 5b2feba Compare February 20, 2025 10:58
@rymnc rymnc force-pushed the chore/impl-temporal-registry-for-v2-tables branch from 5befcaa to e1e7832 Compare February 20, 2025 16:37
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch from 5b2feba to bf6973a Compare February 20, 2025 16:39
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch 4 times, most recently from a159a27 to be1ea4c Compare February 21, 2025 10:39
@rymnc rymnc force-pushed the chore/impl-temporal-registry-for-v2-tables branch from e1e7832 to 63c9a54 Compare February 21, 2025 10:43
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch 3 times, most recently from acd9039 to 508d189 Compare February 21, 2025 10:56
@rymnc rymnc marked this pull request as ready for review February 21, 2025 11:04
@rymnc rymnc requested review from netrome and xgreenx February 21, 2025 11:05
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch from 508d189 to 0d40246 Compare February 21, 2025 12:58
@rymnc rymnc force-pushed the chore/impl-registry-root-calc branch from 0d40246 to 118ba9e Compare February 21, 2025 13:00
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. Some thoughts and comments. Only blocker is the .unwrap_or(...default()) which at least should be unwrap_or_default, but I'd like to see an error there instead.

@rymnc rymnc requested a review from netrome February 21, 2025 13:54
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants