New txpool worker to remove lock contention #2725
Merged
+1,182
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal,
MitchTurner,
netrome,
acerone85,
rafal-ch and
rymnc
as code owners
|
Ty for improvements on the source it's more clear like that. |
Not decrease the reputation of the P2P node if insertion into TxPool failed
xgreenx
previously approved these changes
Feb 19, 2025
xgreenx
previously approved these changes
Feb 19, 2025
rafal-ch
reviewed
Feb 20, 2025
rymnc
reviewed
Feb 21, 2025
Comment on lines
+1
to
+2
| // Define arguments | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Define arguments |
| @@ -77,11 +77,11 @@ pub struct TxPoolArgs { | |||
| pub tx_size_of_p2p_sync_queue: usize, | |||
|
|
|||
| /// Maximum number of pending write requests in the service. | |||
| #[clap(long = "tx-max-pending-write-requests", default_value = "500", env)] | |||
| #[clap(long = "tx-max-pending-write-requests", default_value = "10000", env)] | |||
There was a problem hiding this comment.
do we have to communicate this to external operators>?
| .height_expiration_txs | ||
| .range(..=new_height) | ||
| .map(|(k, _)| *k) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
do we need this collect?
the below loop should work without it too?
There was a problem hiding this comment.
It will not because iterator has read access to the self.pruner.height_expiration_txs
xgreenx
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
When running benches on transaction pool we observed that each thread trying to submit to the same pool with a thread was a costly behavior.
Solution in this PR
We changed the pool to live only in one thread and all communications are managed through channels where priority can be explicitly defined between each tasks.
Side modifications
Now we are sending tx through P2P after their full insertion inside the pool. Before it was done after one round of verification but before the final checks and the pool integration.
Now we are not doing any pool verifications before computing the predicates and the signatures. This pool and input verifications step is now done after the predicate and signatures verifications inside of the pool worker thread.
Checklist
Before requesting review