Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty response body when debug log is enabled #74

Open
wants to merge 1 commit into
base: release/2.0
Choose a base branch
from

Conversation

houbi56
Copy link

@houbi56 houbi56 commented Nov 21, 2022

Change to fix stream already consumed by the LoggingWebDavResponse. Resolves #73

IWebDavResult now writes the result to the http output except for the body which is buffered in a memory stream.
The memory stream is then copied to the httpresult body.

This avoids the executing the result processing twice.

Copy link
Collaborator

@fubar-coder fubar-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good - except one thing I didn't previously think of: The response must not be logged when the response stream isn't seekable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants