Avoid stack overflow when initializing HashBuffers. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `Box::default()` that creates default `HashBuffers` would in debug mode create the default `HashBuffers` struct on the stack and then as a separate step copy it into the heap (i.e. into the `Box`). This would require 164098 bytes of stack space and would trigger stack overflow in some scenarios (e.g. when running Chromium tests built in debug-mode on an iOS device - see https://crbug.com/394824910).
|
This might be related to the same problem that caused this - an upstream change in rust to Will have to check if this change has any performance implications or not (granted that will be dwarfed by sorting the regression noted in #163 if that can be sorted for the next release in any case.) |
|
It doesn't seem to have any notable performance impact so I will just merge as is for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
Box::default()that creates defaultHashBufferswould in debug mode create the defaultHashBuffersstruct on the stack and then (as a separate step copy it) from the stack into the heap (i.e. into theBox). This would require 164098 bytes of stack space and would trigger stack overflow in some scenarios (e.g. when running Chromium tests built in debug-mode on an iOS device - see https://crbug.com/394824910).I have tested that Chromium tests on iOS pass after changes from this commit - see https://crrev.com/c/6244910