Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix hearts not loading #12

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

A-ntoin-e
Copy link
Collaborator

No description provided.

Copy link
Owner

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour la migration DB ça va pas, faut un script d'upgrade pour la db existante.

@@ -29,7 +29,7 @@

create table Configuration (
id bigint not null,
key varchar(255) check (key in ('GOOGLE_MAP_API_KEY','EVENT_START_DATE','EVENT_END_DATE','DISPLAY_FULL_SCHEDULE','DISPLAY_NEW_SPEAKERS','DISPLAY_TALKS','PROMOTED_PAGE','PROMOTED_PAGE_2','TICKETING_URL','TICKETING_OPEN','TICKETING_TRAINING_URL','TICKETING_TRAINING_OPEN','SPONSORING_LEAFLET_URL','CFP_OPEN','CFP_URL','CANCELLED_URL')),
key varchar(255) check (key in ('GOOGLE_MAP_API_KEY','EVENT_START_DATE','EVENT_END_DATE','DISPLAY_FULL_SCHEDULE','DISPLAY_NEW_SPEAKERS','DISPLAY_TALKS','PROMOTED_PAGE','PROMOTED_PAGE_2','TICKETING_URL','TICKETING_OPEN','TICKETING_TRAINING_URL','TICKETING_TRAINING_OPEN','SPONSORING_LEAFLET_URL','CFP_OPEN','CFP_URL','CANCELLED_URL', 'FEEDBACK_URL')),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good. We need a migration file with an alter table Configuration…

src/main/resources/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages_fr.properties Outdated Show resolved Hide resolved
@FroMage FroMage merged commit b854153 into main Jul 2, 2024
1 check passed
@FroMage
Copy link
Owner

FroMage commented Jul 2, 2024

Thanks!

@FroMage FroMage deleted the bugfix/fix_hearts_not_loading branch July 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants