Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading view: action icons position #6297

Merged
merged 24 commits into from
Jun 13, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 13, 2024

inspired by #6261 from @joshka

(default): above title

grafik

grafik

in authors and date row

grafik

grafik

top line article icons configs respected

grafik

How to test the feature manually:

  1. go to config reading, section Articles: header/footer
  2. edit the option
  3. see in reading view

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 13, 2024
@math-GH math-GH added this to the 1.25.0 milestone Apr 13, 2024
@math-GH
Copy link
Contributor Author

math-GH commented Apr 13, 2024

@joshka Please have a look here :) I added you into the CREDITS.md to mention, that parts of this code was made by you (in #6261).

@joshka
Copy link

joshka commented Apr 15, 2024

LGTM. Thanks for the change!

@Alkarex
Copy link
Member

Alkarex commented Apr 25, 2024

Tests failing

app/i18n/fr/conf.php Outdated Show resolved Hide resolved
app/i18n/en/conf.php Outdated Show resolved Hide resolved
app/i18n/en/conf.php Outdated Show resolved Hide resolved
app/i18n/en-us/conf.php Outdated Show resolved Hide resolved
app/i18n/fr/conf.php Outdated Show resolved Hide resolved
app/i18n/en/conf.php Outdated Show resolved Hide resolved
app/i18n/en-us/conf.php Outdated Show resolved Hide resolved
@Alkarex Alkarex merged commit 20f1331 into FreshRSS:edge Jun 13, 2024
2 checks passed
@math-GH math-GH deleted the reading-view-action-icons branch June 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants