Skip to content

feat: add option to hide the channel link #7514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

DontBlameMe99
Copy link
Contributor

@DontBlameMe99 DontBlameMe99 commented Jun 4, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #3193

Description

This adds a option to the settings (parental controls) which allows the Channel Link to be hidden.

Screenshots

image
image
image

Testing

Open various videos, enable and disable the option

Desktop

  • OS: Arch Linux
  • FreeTube version: Newest Development branch (this commit)

Additional context

This was a requested feature (marked with good first issue) and I implemented it.
I am new to contributing actual code to FreeTube. I have previously only contributed themes, so please let me know if anything should be done differently.

DontBlameMe added 2 commits June 4, 2025 07:39
Adds an option to hide the channel link from a video

closes FreeTubeApp#3193
This prevents the sharing actions from being moved to where the profile would be,
once the profile is hidden via the parental controls.
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 4, 2025 05:51
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 4, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined with all our other parental and distraction free settings i think this is a pretty good addition

The only thing im not sure about is the label, Hide Channel Link. Im not sure if its clear enough for a person that is reading this the first time on what this actually does

@PikachuEXE
Copy link
Collaborator

Also Hide Channel Link also hides unsubscribe button and I don't think that's expected just by reading that label

@DontBlameMe99
Copy link
Contributor Author

@PikachuEXE Yeah the name is definitely something which needs to be discussed. I previously also had "Hide Channel Actions" as the name, but because of the issue I changed it. I am not sure of what to call this.

@efb4f5ff-1298-471a-8973-3d47447115dc

any ideas for a better name @absidue @ChunkyProgrammer @kommunarr

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 4, 2025
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 24, 2025

Apologies for the delay. Some suggestions i came up with:

  • Limit Channel Discovery
  • Restrict Channel Access
  • Hide Channel Information

I feel the reason that its so hard to come up with a label is that it isnt clear where this is applied and to what elements. For example in our distraction free setting its clear what element is hidden and on what page it is applied

@DontBlameMe99
Copy link
Contributor Author

@PikachuEXE I would love to hear your opinion as well! (Since I am not sure of what to use (even with @efb4f5ff-1298-471a-8973-3d47447115dc's suggestions)).
For me it would be the best if y'all could basically say "use X" and I just use that name 😅

@PikachuEXE
Copy link
Collaborator

I think Restrict Channel Access is better but that would require this PR to have channel page to display "access restricted"...

@efb4f5ff-1298-471a-8973-3d47447115dc

We already have a setting to hide the subscribe button so maybe this setting can only hide the channel icon and name so we can name this setting properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Unclickable Channel Link
3 participants