-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add option to hide the channel link #7514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Adds an option to hide the channel link from a video closes FreeTubeApp#3193
This prevents the sharing actions from being moved to where the profile would be, once the profile is hidden via the parental controls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combined with all our other parental and distraction free settings i think this is a pretty good addition
The only thing im not sure about is the label, Hide Channel Link. Im not sure if its clear enough for a person that is reading this the first time on what this actually does
Also |
@PikachuEXE Yeah the name is definitely something which needs to be discussed. I previously also had "Hide Channel Actions" as the name, but because of the issue I changed it. I am not sure of what to call this. |
any ideas for a better name @absidue @ChunkyProgrammer @kommunarr |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Apologies for the delay. Some suggestions i came up with:
I feel the reason that its so hard to come up with a label is that it isnt clear where this is applied and to what elements. For example in our distraction free setting its clear what element is hidden and on what page it is applied |
@PikachuEXE I would love to hear your opinion as well! (Since I am not sure of what to use (even with @efb4f5ff-1298-471a-8973-3d47447115dc's suggestions)). |
I think |
We already have a setting to hide the subscribe button so maybe this setting can only hide the channel icon and name so we can name this setting properly? |
Pull Request Type
Related issue
closes #3193
Description
This adds a option to the settings (parental controls) which allows the Channel Link to be hidden.
Screenshots
Testing
Open various videos, enable and disable the option
Desktop
Additional context
This was a requested feature (marked with good first issue) and I implemented it.
I am new to contributing actual code to FreeTube. I have previously only contributed themes, so please let me know if anything should be done differently.