[1.0.0] Use the container for the LdapServer. #76
+889
−484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChadSikorra
force-pushed
the
v1-more_container_work
branch
from
be55a8d to
6744058
Compare
Codecov Report
@@ Coverage Diff @@
## 1.0 #76 +/- ##
============================================
+ Coverage 87.02% 87.88% +0.85%
- Complexity 2129 2144 +15
============================================
Files 154 156 +2
Lines 6552 6642 +90
============================================
+ Hits 5702 5837 +135
+ Misses 850 805 -45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChadSikorra
force-pushed
the
v1-more_container_work
branch
2 times, most recently
from
c1d5243 to
05f3ad9
Compare
…s comes from the container if needed.
ChadSikorra
force-pushed
the
v1-more_container_work
branch
from
05f3ad9 to
85c5547
Compare
…andler should be constructed with it.
…rface params. It will be constructed with the handler if needed.
ChadSikorra
force-pushed
the
v1-more_container_work
branch
from
bef9e38 to
e12ed27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some recent work for a 1.0 release, I implemented a container to start to sort out the dependency graph / interfaces. That was initially focused on the client. I'm now doing the same thing for the LdapServer. Some care needs to be take as some of the instantiated classes should be be reused from the container.
#50