Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hiding of horizontal line in start page #13806

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

efferre79
Copy link
Contributor

No description provided.

@chennes
Copy link
Member

chennes commented May 2, 2024

The reason for putting the element in the layout below was so that it was wider than the First Start box (I was trying to give a clearer visual separator between that region and the "Don't show again" checkbox). I'm not convinced that even in its current incarnation it's serving that purposed, and in the proposed location it's probably entirely superfluous. @FreeCAD/design-working-group do you have any ideas for how to handle the problem of ensuring the checkbox clearly applies to the whole Start screen, and not just the First Start box?

@obelisk79
Copy link

I would probably hold off on this. I'm working through a few other things, but I believe the whole page needs quite a few adjustments before 1.0 goes out the door. I would suggest a tabbed layout for separating the settings bit and the regular start parts. I can mock up a layout, but it will probably be a week before I manage to do so.

@chennes chennes marked this pull request as draft May 3, 2024 19:51
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 15, 2024

@efferre79 I guess the proposal needs some more discussion but just a heads up for the upcoming feature freeze:
If you want this draft PR to be considered for a version 1.0 release, it should be marked ready for review by Monday, 2024-06-03 at the latest. (further details in the 1.0 feature freeze forum announcement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants