[TD]add fallback default template #13784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah you already made a fix here then. So #13794 is duplicate. However in your PR you are adding an empty file to be the new default? Or is it a visibility issue on github? But the file looks like an empty rectangle. |
|
I guess to provide a blank page |
|
It is a blank A4 sheet. Seemed like a reasonable fall back. |
|
But it's not a fall back it's the default. So now the tool new page creates
a white page.
Not sure it's ideal imo.
…On Thu, May 2, 2024, 19:55 Max Wilfinger ***@***.***> wrote:
I guess to provide a blank page
—
Reply to this email directly, view it on GitHub
<#13784 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYO6MOY4RDV3JB4PPPTIC3ZAJ4X5AVCNFSM6AAAAABHDRCCUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRGE3TENJQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Right, the error is gone now but a blank page is created by default. Can't it just be the same default template as before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for issue issue #13539. In PR #13368 the default template was renamed. This PR adds a new fallback template and adjusts the preference function to return the new default template file,
Additional discussion on forum: https://forum.freecad.org/viewtopic.php?t=87239&sid=49290882ca3ba68ee813770b981bb5ce