Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: separate quarter as a separate library #13761

Closed
wants to merge 4 commits into from

Conversation

ppphp
Copy link
Contributor

@ppphp ppphp commented May 1, 2024

It is my question why package like Quarter is compiled with the whole Gui library, and library like Gui should also be separated into some submodule so that FreeCAD does not rely too much on a single package like OCCT, coin3d, or Qt.

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label May 1, 2024
@ppphp ppphp force-pushed the separate_quarter branch 7 times, most recently from a3047c8 to 8c3212d Compare May 8, 2024 09:29
@ppphp ppphp marked this pull request as ready for review May 8, 2024 15:28
@FEA-eng
Copy link
Contributor

FEA-eng commented May 13, 2024

Looks like a desired but also quite big change. Someone should review this. Maybe @wwmayer could take a look?

@wwmayer
Copy link
Contributor

wwmayer commented May 13, 2024

There are many differences between the forked Quarter code in FreeCAD and the upstream version of the Coin3D project. Now by moving the code to a separate library using the same library name as the original can cause problems for people who use pivy because the two libraries are not binary compatible. The result will lead to unexpected failures or even random crashes.

@ppphp
Copy link
Contributor Author

ppphp commented May 16, 2024

There are many differences between the forked Quarter code in FreeCAD and the upstream version of the Coin3D project. Now by moving the code to a separate library using the same library name as the original can cause problems for people who use pivy because the two libraries are not binary compatible. The result will lead to unexpected failures or even random crashes.

OK, I will try making binary compatible.

@ppphp ppphp closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants