MoonchildProductions#1251 - Part 11: libpng uses C89 now to avoid buf…

…fer overflows. https://bugzilla.mozilla.org/show_bug.cgi?id=1371266 pnggroup/libpng@12e63e9 This sounds absurd, and the fact that we had to change a C++ comment to a C-style comment on account of this may seem hilarious and inconsequential, but this isapparently not a joke and leaving it as it is now may be a bad idea.
FranklinDM · Oct 21, 2019 · 7966d22 · 7966d22
1 parent 52f2321
commit 7966d22
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/media/libpng/moz.build b/media/libpng/moz.build
@@ -51,3 +51,6 @@ FINAL_LIBRARY = 'gkmedias'
 
 # We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
+
+if CONFIG['GNU_CC']
+    CFLAGS += ['std=c89']
diff --git a/mozilla-config.h.in b/mozilla-config.h.in
@@ -13,7 +13,7 @@
 #endif
 #endif
 
-// Expands to all the defines from configure.
+/* Expands to all the defines from configure. */
 #undef ALLDEFINES
 
 /*
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,7 @@ @@
     #endif
     #endif
-    // Expands to all the defines from configure.
+    /* Expands to all the defines from configure. */
     #undef ALLDEFINES
     /*
@@ Expand Down @@