Open
Conversation
* Use filtered, processable scrobbles in for-loop to avoid any weird in-place array splice issues when iterating * Add more logging with labels/ids to make logging more readable * Move dead scrobble removal function closer blocks where it should happen
* Return 200 when processing all, don't wait to finish to prevent response timeout * Use event stream to update/remove/add dead scrobbles in ui #489
✅ Deploy Preview for multi-scrobbler ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
Describe your changes
Issue number and link, if applicable
#489
#488