Skip to content

Conversation

@owendaprile
Copy link
Contributor

Checklist before requesting a review

Type of change

  • New feature (non-breaking change which adds functionality)

Describe your changes

This updates the teal.fm client to also write artistMbId alongside artistName as described in the lexicon.

This assumes that the order of artists in TrackData.artists and BrainzMeta.artist are the same, which appears to be the case from the other sources I checked.

For plays with empty/unmatched BrainzMeta.artist items, nothing will be written.

@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for multi-scrobbler canceled.

Name Link
🔨 Latest commit ecb9d1b
🔍 Latest deploy log https://app.netlify.com/projects/multi-scrobbler/deploys/694b18be5585b30008e0190d

@FoxxMD
Copy link
Owner

FoxxMD commented Dec 28, 2025

thanks for the contribution!

This assumes that the order of artists in TrackData.artists and BrainzMeta.artist are the same

The play artist field is something I've been meaning to refactor to avoid this assumption. I think this is correct for all cases at the moment but there's no gaurantee, and album artist parsing from various sources might mess this up.

I need to create some test cases for this first, or just do the refactor, to make sure this is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants