feat(player): Real time positional player state - #212
Merged
Conversation
* Introduce positional and non-positional data structures * Refactor state player into types of each * Refactor listen ranges and progress into types of each * Implment (internal) real-time player and base positional player seeked/repeat on real-time drift instead of just reported position * Refactor tests to use (emulated) real-time components
FoxxMD
added
enhancement
Contributor
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Describe your changes
While this is a large fundamental restructure it (should) only functionally affect Plex API Source as it makes it more accurate since we don't rely solely on reported position for calculated state and listening range.
On the dev side it makes player state logic much clearer as there are way few if-else blocks just checking for
position === undefined.