Custom sort functionality - Community#470 #2424
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is a big step towards resolving https://community.getmailspring.com/t/custom-email-sorting/470
The update brings some basic sort functionality to the thread (including search results).
As I'm limited by the DB, you only have
date
andsubject
,from
andsize
would require some extra fields (unread
is possible, though we already have the unread "folder")Currently the feature remembers the
order
and implements it when you switch folders or restart the app.Q. This seems almost redundant as, after the first sort swap, it will never be triggered again. Maybe have the new setting set by default? Then this can be removed
https://github.com/glenn2223/Mailspring/blob/5b9493f87cef86c573593455844d330472d49e70/app/src/mailbox-perspective.ts#L412-L414
Q. Not sure about the naming of the new "setting"
Q. Where do we stand on increasing the sort by options?